PATCH: minor corrections to gthr-dce.h
John David Anglin
dave@hiauly1.hia.nrc.ca
Fri May 18 19:34:00 GMT 2001
> > 2001-05-15 John David Anglin <dave@hiauly1.hia.nrc.ca>
> >
> > * gthr-dce.h (UNUSED): Attribute unused macro.
> > (__gthread_key_dtor): Make arguments UNUSED.
> > (__gthread_key_delete): Revise for compatibility with DRAFT4
> > implementation.
> Based on your comments, this patch is not critical for the GCC 3 release,
> correct?
Originally, I thought that this patch was not critical for the GCC release.
I have been working to the correct the v3 (dce) thread implementation. The v3
modules eh_globals.cc and eh_alloc.cc include gthr.h. While an undeclared
function is just a warning under C, it is a hard error under C++:
/xxx/gnu/gcc-3.0/objdir/gcc/xgcc -B/xxx/gnu/gcc-3.0/objdir/gcc/ -nostdinc++ -L/xxx/gnu/gcc-3.0/objdir/hppa1.1-hp-hpux10.20/threads/libstdc++-v3/src -L/xxx/gnu/gcc-3.0/objdir/hppa1.1-hp-hpux10.20/threads/libstdc++-v3/src/.libs -B/usr/local/hppa1.1-hp-hpux10.20/bin/ -B/usr/local/hppa1.1-hp-hpux10.20/lib/ -isystem /usr/local/hppa1.1-hp-hpux10.20/include -threads -I../../../../../libstdc++-v3/../gcc -I../../../../../libstdc++-v3/../include -I../../../../../libstdc++-v3/include -I../../../../../libstdc++-v3/include/std -I../../../../../libstdc++-v3/include/c_std -I../include -I../../../../../libstdc++-v3/libsupc++ -g -O2 -threads -fno-implicit-templates -Wall -Wno-format -W -Wwrite-strings -Winline -fdiagnostics-show-location=once -g -c ../../../../../libstdc++-v3/libsupc++/eh_alloc.cc -fPIC -DPIC -o eh_alloc.o
In file included from ../../../../../gcc/gthr.h:87,
from ../../../../../libstdc++-v3/libsupc++/eh_alloc.cc:38:
../../../../../gcc/gthr-dce.h: In function `int __gthread_key_delete(int)':
../../../../../gcc/gthr-dce.h:424: `pthread_key_delete' undeclared (first use
this function)
../../../../../gcc/gthr-dce.h:424: (Each undeclared identifier is reported only
once for each function it appears in.)
make[8]: *** [eh_alloc.lo] Error 1
Thus, the patch needs a more detailed review for the branch.
Dave
--
J. David Anglin dave.anglin@nrc.ca
National Research Council of Canada (613) 990-0752 (FAX: 952-6605)
More information about the Gcc-bugs
mailing list