PATCH: new flag to say when things are instantiated

Joseph S. Myers jsm28@cam.ac.uk
Wed Nov 8 14:32:00 GMT 2000


On Wed, 8 Nov 2000, Brendan Kehoe wrote:

> 2000-11-08  Brendan Kehoe  <brendan@zen.org>
>
> 	* decl2.c (warn_instantiations): New variable.
> 	(lang_decode_option): Set it for -Winstantiations.
> 	* pt.c (instantiate_decl): If WARN_INSTANTIATIONS, tell the user
> 	when an instantiatiation has taken place.
> 	(instantiate_class_template): Likewise for classes.
> 	* lang-options.h: Add -Winstantiations/-Wno-instantiations.

Surely any new option should come with a patch to invoke.texi to document
it?  I think documentation for any user-visible features should be
considered a necessary part of any patch, not an optional extra.  (I'd
also say the same of testcases - you must have tested the patch, so can at
least add a testcase to the testsuite as a sanity check to ensure that
no-one breaks the option by accident.)

-- 
Joseph S. Myers
jsm28@cam.ac.uk



More information about the Gcc-bugs mailing list