Traditional C chokes on struct/union initialization in new cpplex.c
Zack Weinberg
zack@wolery.cumb.org
Thu Jul 6 10:15:00 GMT 2000
On Thu, Jul 06, 2000 at 01:03:26PM -0400, Kaveh R. Ghazi wrote:
> > From: Jeffrey A Law <law@cygnus.com>
> >
> > > I hacked up this patch and got midway through stage2 so far. Assuming
> > > bootstrap succeeds, ok to install?
> > >
> > > --Kaveh
> > >
> > >
> > > 2000-07-05 Kaveh R. Ghazi <ghazi@caip.rutgers.edu>
> > >
> > > * cpplex.c (placemarker_token, eof_token): Don't initialize struct
> > > union member in traditional C.
> >
> > The way this has been handled in BFD and elsewhere is to simply
> > omit the union initialization when ___STDC__.
> >
> > See this change in BFD as an example.
> >
> > 1999-08-06 Ian Lance Taylor <ian@zembu.com>
> >
> > * section.c (global_syms): Only initialize union field if
> > __STDC__.
> >
> > Unless there is significant benefit, we should adopt the same
> > conventions as other GNU projects.
>
> Okay, I'll do s/ANSI_PROTOTYPES/__STDC__/ in the patch.
>
> BTW the 3-stage completed, any other objections or is it good to go?
Just a tidiness issue: perhaps you should have the definition of
UNION_INIT in system.h so that it is available to any other file that
might need this in the future.
zw
More information about the Gcc-bugs
mailing list