untested changes (was re: patch applied to reload1.c)

David S. Miller davem@dm.cobaltmicro.com
Fri Sep 25 00:28:00 GMT 1998


There is no way these changes were tested before being installed.

I've just checked in the following fix, but I fear there may be more
hidden treasure in these reload changes since even this obvious crash
did not get caught.

Thu Sep 24 22:12:16 1998  David S. Miller  <davem@pierdol.cobaltmicro.com>

	* reload1.c (reload_combine): Initialize set before using.

--- reload1.c.~2~	Thu Sep 24 14:59:10 1998
+++ reload1.c	Thu Sep 24 22:08:06 1998
@@ -9274,7 +9274,7 @@
 
 	 First, check that we have (set (REGX) (PLUS (REGX) (REGY)))
 	 and that we know all uses of REGX before it dies.  */
-      if (set
+      if ((set = single_set (insn)) != NULL_RTX
 	  && GET_CODE (SET_DEST (set)) == REG
 	  && (HARD_REGNO_NREGS (REGNO (SET_DEST (set)),
 				GET_MODE (SET_DEST (set)))



More information about the Gcc-bugs mailing list