[PATCH v3] [17 Regression] PR126964 4-5% slowdown of tonto of Zen{2,3,4,5}

[Jerry D]

The master branch has been updated by Jerry DeLisle <jvdelisle@gcc.gnu.org>:

https://gcc.gnu.org/g:5e8f400f12c27a5c8c0bacc6ac5975c94274db1e

This was the libgfortran Part 1 of 2. Comments fixed.

I plan to commit the Part 2 of 2 later today.

Jerry

On 9/6/26 7:47 AM, Jerry D wrote:
> On 9/6/26 4:13 AM, Paul Richard Thomas wrote:
>> Hi Jerry,
>>
>> Maybe it is a matter of taste but the comments are, to my mind, overly verbose:
>>
>> +/* Return the spacing in bytes of the elements of DESC in dimension N.  The
>> +   stride counts spans rather than elements, so descriptors that denote the
>> +   same storage sequence can hold different combinations of the two: elements
>> +   that are subobjects of larger ones are described either by the spacing of
>> +   the larger objects as the span, or by that spacing folded into the stride
>> +   with the element length as the span.  The product is what the two have in
>> +   common.  */
>>
>> /* If the stride is not set, use the element length.  */ ?
>>
>> Likewise,
>>
>> +  /* The element length is normally held by the dtype, but the descriptor
>> +     built for a polymorphic pointer to a character section holds the
>> +     spacing of the elements there instead, and carries the length
>> +     separately.  Require the two to agree on one or the other: if they
>> +     agree on neither, the storage sequences differ.  */
>>
>> /* Require that the storage sequences are the same.  */ ?
>>
>> The patch itself is fine. OK by me.
>>
>> Cheers
>>
>> Paul
>>
> Thanks Paul, I will trim the comments
> 
> Jerry