[PATCH 0/4] Fortran: Improve flow of intrinsics/library documentation [PR47928]

[Sandra Loosemore]

On 2/28/25 02:56, Andre Vehreschild wrote:
> Hi Sandra,
> 
> thanks for taking on the laborious task. I have browsed over the changes and
> found:
> 
> Patch 3 in intrinsic.texi:
> 
> @@ -2071,6 +2071,9 @@ end program atomic
>   @cindex Atomic subroutine, ADD with fetch
> 
>   @table @asis
> +@item @emph{Synopsis}:
> +@code{CALL ATOMIC_FETCH_ADD (ATOM, VALUE, old [, STAT])}
> +
> `old` should be uppercase here, too, for consistency.
> 
> Yes, I know, that is nothing you changed. I just stumbled over it and while we
> are at it, let's address it.
> 
> Same for:
> 
> @@ -3074,6 +3074,9 @@ end program test_btest
>   @cindex pointer, C association status
> 
>   @table @asis
> +@item @emph{Synopsis}:
> +@code{RESULT = C_ASSOCIATED(c_ptr_1[, c_ptr_2])}
> 
> With uppercasing in the following paragraph needed, too. And I vote for using
> CPTR1 and CPTR2 instead.
> 
> Same here:
> @@ -3177,6 +3177,9 @@ end program main
>   @cindex pointer, C address of pointers
> 
>   @table @asis
> +@item @emph{Synopsis}:
> +@code{CALL C_F_PROCPOINTER(cptr, fptr)}
> 
> and here:
> @@ -3235,6 +3235,9 @@ end program main
>   @cindex pointer, C address of procedures
> 
>   @table @asis
> +@item @emph{Synopsis}:
> +@code{RESULT = C_FUNLOC(x)}
> +
> 
> I'd say: "Ok, I'll stop." here, but that is the list of changes needed to get
> the description in intrinsic.texi neat.
> 
> In part 4 of your patch, can you rephrase:
> 
> @@ -1118,6 +1114,10 @@ program test_allocated
>     if (.not. allocated(x)) allocate(x(i))
>   end program test_allocated
>   @end smallexample
> +
> +@item @emph{Standard}:
> +Fortran 90 and later.  Note, the @code{SCALAR=} keyword and allocatable
> +scalar entities are available in Fortran 2003 and later.
>   @end table
> 
> to
> 
> +Fortran 90 and later; for @code{SCALAR=} keyword and allocatable
> +scalar entities Fortran 2003 and later.
> 
> Just for consistency.
> 
> With these changes, ok for mainline.
> 
> Thank you very much for taking on that laborious task. My deepest respect!

Thanks for the review!  I've pushed the changes now, along with the 
attached additional patch to address those existing minor issues you 
identified.  As I said, there are a lot of remaining markup and 
formatting problems in there as well.  :-(

-Sandra

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fortran-Small-fixes-in-intrinsic.texi.patch
Type: text/x-patch
Size: 3481 bytes
Desc: not available
URL: <https://gcc.gnu.org/pipermail/fortran/attachments/20250302/0e80a140/attachment.bin>