[PATCH v3 0/2] fortran: Fix specification checks [PR111781]

[Paul Richard Thomas]

Hi Mikael,

Sorry, I am replying to these in the order that they appear in my intray :-)

OK for mainline and, if you wish, 13-branch.

Thanks

Paul


On Tue, 19 Mar 2024 at 15:49, Mikael Morin <mikael@gcc.gnu.org> wrote:

> Hello,
>
> these patches correct diagnostics dealing with variables in specification
> expressions.
> The first patch is a testsuite change, which fixes invalid specification
> expressions that the second patch would diagnose.
> The second patch removes a spurious diagnostic when a dummy procedure is
> involved, and enables more valid ones, as visible in the testcases from the
> first patch.
>
> I haven't tested it again (same code as v2), but I plan to do it before
> the final push.
> Ok for master?
>
> Mikael
>
> v2 -> v3 changes:
>
>   - Correct first name in testcase comment
>   - Clarify and correct log and changelog text from second patch
>   - Target current stage (stage4) instead of next (stage1)
>
> v1 -> v2 changes:
>
>   - Fix condition guarding sym->result access.
>
>
> Mikael Morin (2):
>   testsuite: Declare fortran array bound variables
>   fortran: Fix specification expression error with dummy procedures
>     [PR111781]
>
>  gcc/fortran/expr.cc                           |  8 +-
>  gcc/fortran/gfortran.h                        |  4 +-
>  gcc/fortran/resolve.cc                        | 77 +++++++++----------
>  gcc/fortran/symbol.cc                         | 58 ++++++++++++++
>  .../gfortran.dg/graphite/pr107865.f90         |  2 +-
>  gcc/testsuite/gfortran.dg/pr101267.f90        |  2 +-
>  gcc/testsuite/gfortran.dg/pr112404.f90        |  2 +-
>  gcc/testsuite/gfortran.dg/pr78061.f           |  2 +-
>  gcc/testsuite/gfortran.dg/pr79315.f90         |  6 +-
>  gcc/testsuite/gfortran.dg/spec_expr_8.f90     | 24 ++++++
>  gcc/testsuite/gfortran.dg/spec_expr_9.f90     | 19 +++++
>  gcc/testsuite/gfortran.dg/vect/pr90681.f      |  2 +-
>  gcc/testsuite/gfortran.dg/vect/pr97761.f90    |  2 +-
>  gcc/testsuite/gfortran.dg/vect/pr99746.f90    |  2 +-
>  14 files changed, 152 insertions(+), 58 deletions(-)
>  create mode 100644 gcc/testsuite/gfortran.dg/spec_expr_8.f90
>  create mode 100644 gcc/testsuite/gfortran.dg/spec_expr_9.f90
>
> --
> 2.43.0
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://gcc.gnu.org/pipermail/fortran/attachments/20240319/333c77b2/attachment.htm>