[Patch, Fortran, 96418] Fix Test coarray_alloc_comp_4.f08 ICEs

Harald Anlauf anlauf@gmx.de
Fri Jun 14 19:43:47 GMT 2024


Hi Andre,

the patch looks fairly simple and obvious, so OK from my side.

***

Regarding the testsuite: since you renamed one of the testcases
gfortran.dg/coarray_alloc_comp_* and moved it to gfortran.dg/coarray/,
I checked and noticed that there are other similar runtime tests for
coarrays (while some are compile-time only tests).

Do we plan to "clean" this up and move more/all related runtime
tests to the coarray/ subdirectory?  What is the general opinion on
this?

***

Thanks for the patch!

Harald


Am 14.06.24 um 09:22 schrieb Andre Vehreschild:
> Hi all,
>
> I messed up renaming of the coarray_alloc_comp-test. This is fixed in the second
> version of the patch. Sorry for the inconvenience.
>
> Additionally I figured that this patch also fixed PR fortran/103112.
>
> Regtests ok on x86_64 Fedora 39. Ok for mainline?
>
> Regards,
> 	Andre
>
> On Tue, 11 Jun 2024 16:12:38 +0200
> Andre Vehreschild <vehre@gmx.de> wrote:
>
>> Hi all,
>>
>> attached patch has already been present in 2020, but lost my attention. It
>> fixes an ICE in the testsuite. The old mails description is:
>>
>> attached patch fixes PR96418 where the code in the testsuite when compiled
>> with -fcoarray=single  lead to an ICE. The reason was that the coarray object
>> was derefed as an array, but it was no array. Introducing the test for the
>> descriptor removes the ICE.
>>
>> Regtests ok on x86_64-linux/Fedora 39. Ok for mainline?
>>
>> Regards,
>> 	Andre
>> --
>> Andre Vehreschild * Email: vehre ad gmx dot de
>
>
> --
> Andre Vehreschild * Email: vehre ad gmx dot de



More information about the Fortran mailing list