[patch, shared coarrays, committed] Make header use more consistent

Nicolas König nk@koenigni.com
Wed Oct 28 18:05:53 GMT 2020


Hi Andre,

I'll make another pass after I'm done implementing stat & errmsg to 
remove any reference to native coarrays I find.

Kind regards,

   Nicolas

On 28/10/2020 09:25, Andre Vehreschild wrote:
> Hi Nicolas, Thomas,
> 
> are you planing to also rename the directory and library name from "nca" to
> "shared_caf" or the like?
> 
> Regards,
> 	Andre
> 
> On Tue, 27 Oct 2020 17:18:21 -0400
> David Edelsohn via Fortran <fortran@gcc.gnu.org> wrote:
> 
>> The current COARRAYS branch correctly bootstraps on AIX.  Thanks for
>> correcting the contents and ordering of the header files.
>>
>> Thanks, David
>>
>> On Tue, Oct 27, 2020 at 1:31 PM Thomas Koenig <tkoenig@netcologne.de> wrote:
>>>
>>> I just committed
>>>
>>> https://gcc.gnu.org/g:0c261d5b5c931d9e9214d06531bdc7e9e16aeaab
>>>
>>> to hopefully fix the header issue on the native_coarray branch.
>>>
>>> If anybody wants to give this a spin, please go right ahead.
>>>
>>> I've also discussed with Nicolas on how best to proceed.  The
>>> best way forward is probably to merge the branch into trunk at
>>> the end of stage 1 and follow Richard's suggestion to use configure.tgt
>>> to only compile the shared coarray library for systems where it is
>>> known to at least compile. As people test more systems, we can then
>>> add these to configure.tgt.
>>>
>>> Best regards
>>>
>>>          Thomas
>>>
>>> Always include libgfortran.h first; sanitize header dependencies.
>>>
>>> libgfortran/ChangeLog:
>>>
>>>          * nca/coarraynative.c: Do not include util.h. Remove commented
>>>          include for stdlib.h..
>>>          * nca/collective_subroutine.c: Move #include <string.h> after
>>>          other #include statement.
>>>          * nca/hashmap.c: Include shared_memory.h and allocator.h
>>>          * nca/hashmap.h: Remove includess.
>>>          * nca/libcoarraynative.h: Include only those headers which
>>>          are needed.
>>>          * nca/shared_memory.c: Do not include util.h
>>>          * nca/shared_memory.h: Do not include other headers.
>>>          * nca/sync.c: Move include of string.h after other headers.
>>>          * nca/sync.h: Remove include of shared_memory.h and alloc.h.
>>>          * nca/util.h: Do not include stdint.h and stddef.h; include
>>>          limits.h and assert.h.
>>>          * nca/wrapper.c: Remove include for sync.h, util.h and
>>>          collective_subroutine.h. Move include of string.h after other
>>>          headers.
>>>
> 
> 
> --
> Andre Vehreschild * Email: vehre ad gmx dot de
> 


More information about the Fortran mailing list