*ping* [patch, fortran] PR 27318, warn if interfaces do not match

Thomas Koenig tkoenig@netcologne.de
Tue Jun 23 17:41:13 GMT 2020


Hi Dominique,


> I see
> 
> FAIL: gfortran.dg/error_recovery_1.f90   -O  (test for excess errors)
> FAIL: gfortran.dg/use_15.f90   -O  (test for excess errors)
> 
> error_recovery_1.f90 has the expected warning:
> 
> /opt/gcc/work/gcc/testsuite/gfortran.dg/error_recovery_1.f90:12:14:
> 
>      5 |      subroutine foo (x)
>        |                   2
> ......
>     12 | subroutine FOO
>        |              1
> Warning: 'foo' has the wrong number of arguments between (1) and (2)
> 
> and gfortran.dg/use_15.f90 finishes with:
> 
> /opt/gcc/work/gcc/testsuite/gfortran.dg/use_15.f90:37:3:
> 
>     37 | END
>        |   1
> Error: Name 'my_sub' at (1) is an ambiguous reference to 'my_sub' from 
> current program unit

Thanks for checking, I'll try to include all affected error messages
for the next round.

> How difficult would it be to display the INTENT lines rather the 
> SUBROUTINE ones?

Rather difficult; I am using the standard error reporting machinery
here.  Changing the location would make sense for better readability,
but that would be a separate patch (and possibly a large one).

> IMO it would be time to clarify who is or isn't a reviewer.
> Before I left off for six month some people (Jerry and Paul)
> considered me as a reviewer while others didn't.

The official list at https://gcc.gnu.org/fortran/ is a bit
outdated. We should be able to come to a consensus about that
soon, and document that.

Regards

	Thomas


More information about the Fortran mailing list