[Patch, Fortran] PR 89601: [8/9 Regression] [PDT] ICE: Segmentation fault (in resolve_component)

Steve Kargl sgk@troutmask.apl.washington.edu
Mon Mar 11 22:33:00 GMT 2019


On Mon, Mar 11, 2019 at 10:09:02PM +0100, Janus Weil wrote:
> 
> Technically the ICE is a regression, but since it happens on invalid
> code only, backporting is not essential IMHO (but might still be
> useful). Ok for trunk? And 8-branch?

Looks good to me with a minor suggestion.  See below.
You may want to wait a bit or ping Paul to give him
a chance to peek at the patch.

>    if (gfc_match_char (')') == MATCH_YES)
> -    goto ok;
> +  {        
> +    if (typeparam)
> +      {
> +	gfc_error_now ("A parameter name is required at %C");

Can you insert "type" so the error reads "A type parameter name"?
Unfortunately, the words parameter has a few too many meanings.

-- 
Steve



More information about the Fortran mailing list