[committed, openmp/openacc] Tweak error message for mapped parameters

Andrew Stubbs ams@codesourcery.com
Fri Jul 5 16:03:00 GMT 2019


On 05/07/2019 15:49, Jakub Jelinek wrote:
>> OK, here is an alternative patch that merely tries to make the error message
>> more informative.
>>
>> Basically, the user needs to get past "it isn't working but I need that
>> value in this kernel", so hopefully this will help get them there.
>>
>> WDYT?
> 
> I don't like it, I'd end the message where you put ;, the rest doesn't make
> sense and will just confuse users.  For one, the compiler should know if the
> parameter needs to be copied or not, so doesn't need to talk about
> probability thereof, and if it needs to be copied, it should be the compiler
> that arranges that (PR90779) and the user has no way to overide or force
> that behavior.

Here's what Jakub approved via IRC. Now committed.

Thanks Jakub

Andrew
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 190705-map-parameters-3.patch
Type: text/x-patch
Size: 1105 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/fortran/attachments/20190705/bdeef560/attachment.bin>


More information about the Fortran mailing list