Patch for bug 47030

[Steve Kargl]

On Sun, Jan 06, 2019 at 09:02:31AM -0800, Marco Atzeri wrote:
> Am 06.01.2019 um 07:19 schrieb Thomas Koenig:
> > Hi Marco,
> > 
> >> The copyright assignment was completed, and I uploaded a
> >> updated version of the patch
> >>
> >> https://gcc.gnu.org/bugzilla/attachment.cgi?id=45348
> >>
> >> that passes the check_GNU_style.sh verification.
> > 
> > Excellent!
> > 
> > Can you submit the patch using the normal procedure,
> > with a ChangeLog entry and a test case?
> > 
> > Regards
> > 
> >  Thomas
> 
> What you mean as test case ?
> 
> I put a test in the bug entry as attachment
> https://gcc.gnu.org/bugzilla/attachment.cgi?id=44950
> but I have no idea how to implement formally for
> the build
> 

Marco, 

Add the testcase(s) to the gcc/testsuite/gfortran.dg directory.
Either use a descriptive name for the testcase(s) or PR number.  
For example, for this PR you may have 

gcc/testsuite/gfortran.dg/pr44950_1.f90
gcc/testsuite/gfortran.dg/pr44950_2.f90

The number of testcases depends on what your patch does.  Here,
pr44950_1.f90 may test that error messages are correctly issued;
while pr44950_2.f90 tests that gfortran produces the correct
result.

I haven't looked at your patch, but suppose you changed
gcc/fortran/resolve.c.  You create your diff by

svn add gcc/testsuite/gfortran.dg/pr44950_1.f90 
svn add gcc/testsuite/gfortran.dg/pr44950_2.f90 
svn diff gcc/fortran/resolve.c \
   gcc/testsuite/gfortran.dg/pr44950_1.f90 \
   gcc/testsuite/gfortran.dg/pr44950_2.f90 > pr44950.diff

In a separate text file, create the ChangeLog entries that
will be add to gcc/fortran/ChangeLog and gcc/testsuite/ChangeLog
when your patch is actually committed.  ChangeLog entries have
the form

2019-01-06  Your Name  <your_email_address>
<blank line>
<tab>PR fortran/44950
<tab>* resolve.c (name of function changed):  What changed here (be brief).
     (2nd function changed): What changed here.


2019-01-06  Your Name  <your_email_address>
<blank line>
<tab>PR fortran/44950
<tab>* gfortran.dg/pr44950_1.f90: New test.
<tab>* gfortran.dg/pr44950_2.f90: Ditto.

Now, send email to fortran@gcc.gnu.org and gcc-patches@gcc.gnu.org
with the ChangeLog entries in the body of the email, tell us how
you tested the patch, and include the diff as an attachment.

See https://gcc.gnu.org/ml/fortran/2019-01/msg00015.html


-- 
Steve