[fortran, patch] IEEE intrinsic modules (ping)

[Thomas Schwinge]

Hi!

While looking for something else -- isn't that always how it happens ;-)
-- I noticed one thing here:

On Wed, 25 Jun 2014 01:41:02 +0200, FX <fxcoudert@gmail.com> wrote:
> I’ll wait a few more days to commit, so others can comment/review and I am sure to be around if there is fallout.

(This got committed to trunk in r212102.)

> --- gcc/testsuite/gfortran.dg/ieee/ieee.exp	(revision 0)
> +++ gcc/testsuite/gfortran.dg/ieee/ieee.exp	(revision 0)
> @@ -0,0 +1,59 @@
> +[...]
> +global DEFAULT_FFLAGS
> +if ![info exists DEFAULT_FFLAGS] then {
> +    set DEFAULT_FFLAGS ""
> +}
> +[...]

Per my understanding of DejaGnu (and please correct me if that's wrong),
in the same 'runtest' instance, 'global' variables persist from one
'*.exp' file to another.  (Which is something debatable, in my
opinion...)

All other '*.exp' files that back then did define 'DEFAULT_FFLAGS' (using
this same construct as shown above), and it's still the same now, are
using " -pedantic-errors" instead of the empty string.  Thus this setting
of 'DEFAULT_FFLAGS' is not idempotent, depends on whether
'gfortran.dg/ieee/ieee.exp', or an other defining '*.exp' file is
executed first.

By default, first comes 'gfortran.dg/coarray/caf.exp' (nowadays, did not
yet exist back then), then 'gfortran.dg/dg.exp', then
'gfortran.dg/ieee/ieee.exp'.  (And, sometimes also
'gcc.target/powerpc/ppc-fortran/ppc-fortran.exp'.)

And, as I just noticed, 'runtest' seems to always sort the specified
'*.exp' files (?!), so even when you invoke something like
"check-gcc-fortran RUNTESTFLAGS='ieee.exp dg.exp'" to try to provoke some
regressions to appear, you'd still get 'dg.exp' executed first.  The
empty string setting in 'ieee.exp' was never really active -- only if
executed on its own, etc.

Fortunately, 'ieee.exp' seems to behave the same way whether running with
or without '-pedantic-errors', so I propose to simply unify that setting,
see attached.  OK to commit this to all relevant branches?  If approving
this patch, please respond with "Reviewed-by: NAME <EMAIL>" so that your
effort will be recorded in the commit log, see
<https://gcc.gnu.org/wiki/Reviewed-by>.


Grüße
 Thomas


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-testsuite-Fortran-Consistently-set-DEFAULT_FFLAGS.patch
Type: text/x-diff
Size: 1565 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/fortran/attachments/20190228/d91b3734/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 658 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/fortran/attachments/20190228/d91b3734/attachment.sig>