[patch] libgomp/openacc.f90 – clean-up public/private attributes

Tobias Burnus tobias@codesourcery.com
Wed Dec 11 12:48:00 GMT 2019


This patch cleans up the public/private handling in libgomp/openacc.f90:

* module openacc_kinds marked symbols explicitly as public and private 
(but default is public). Make this explicit by a 'PUBLIC' and remove the 
(redundant) explicit 'public :: <symb>' lines.

* 'module openacc' had a bunch of 'public :: ' lines but the default was 
already 'public'. Changed this to 'private' and marked the 
use-associated 'openacc_kinds' symbols as 'public' and added 'public' 
statements for the two missing items. (Net effect: this will hide all 
openacc_internal symbols.)

I think this patch is rather obvious. Nonetheless: are the comments?
(If not, I will commit it in the next days.)

Tobias

PS: I found the two missing symbols by looking at the 'interface <name>' 
lines; 'module openacc' has only those + the version symbol.

PPS: I have filled PR 92913 as gfortran feature request to compare the 
'interface' block's procedure declarations with the actual procedure 
declarations outside of the modules; as, unfortunately, no 
argument-mismatch check exists, currently.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: openacc.f90.diff
Type: text/x-patch
Size: 2452 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/fortran/attachments/20191211/ae5ec1ae/attachment.bin>


More information about the Fortran mailing list