[PATCH][RFC]Overloading intrinsics

[Martin Liška]

On 11/10/18 9:46 PM, Bernhard Reutner-Fischer wrote:
> On 10 November 2018 10:36:06 CET, "Martin Liška" <mliska@suse.cz> wrote:
> 
>>>> !GCC$ builtin sinf attributes omp_simd_notinbranch

Hello.

> 
> I would expect "attribute" singular, like in C.

Plural form is more aligned with e.g. '!GCC$ attributes NO_ARG_CHECK :: buf' ?

> 
> I'm not opposed to your approach, but did we consider using -include glibc-simd-math.h via spec if lets say -O3 or  -mveclibabi=glibc ?

Richi?

> 
> +      /* Make a guard to prevent recursive inclusion.  */
> +      static bool preinclude_done = false;
> +      const char *preinc = targetcm.c_preinclude ();
> 
> Hm. Why don't you call the target hook only if !preinclude_done?

Because otherwise I would see following error:
math-vector-fortran.h:1: Error: File 'math-vector-fortran.h' is being included recursively

Thanks,
Martin

> 
> +      if (!preinclude_done && preinc != NULL)
> +	{
> +	  preinclude_done = true;
> +	  if (!load_file (preinc, NULL, false))
> +	    exit (FATAL_EXIT_CODE);
> +	}
> +
> 
> thanks,
>