[patch, libgfortran] PR78351 comma not terminating READ of formatted input field

Thomas Koenig tkoenig@netcologne.de
Thu Nov 8 19:14:00 GMT 2018


Hi Jerry!

> Hi all,
> 
> The attached patch adds code in read_sf_internal to handle early 
> termination of reads in the presence of comma's. This is to support 
> legacy codes which are not standard conforming as far as we can tell.
> 
> The additions are executed only if -std=legacy is given at compile time. 
>   It does not support kind=4 internal units since in legacy years there 
> should be no kind=4 internal units.
> 
> I have provuded a simplified test case for various combinations of comma 
> embedded strings.
> 
> This has been regression tested on x86_64-pc-linux-gnu.
> 
> OK for trunk?

Yes, OK. I like the fact that the old, slow behavior is restricted
to -std=legacy :-)

> This use to work way back in early versions so should probably go to 7 
> and 8 branches. Opinions welcome.

I agree, it should go in.

Thanks a lot for the patch!

Regards

	Thomas



More information about the Fortran mailing list