[Patch, Fortran, committed] PR 46459: ICE (segfault): Invalid read in compare_actual_formal [error recovery]

[Janus Weil]

Hi Andre,

> well, is it really that obvious?

well ... what can I say. If you wanna be strict about it, I guess
there is no such thing as an "obvious patch". There is basically
always something that you can miss, or that can be improved. Mikael's
patch was obvious to me in the sense that it is clear and simple and
fixes the ICE without any side effects. Thus it's a clear improvement,
and it has been rotting in bugzilla for over five years.

Are you implying that it was premature to commit it as 'obvious'?


> It fixes the ICE, correct. But what about
> cases where the actual has an explicit interface, but is not a variable? Like
> in:
> [...]
> Can you comment
> having thought about this somewhat?

In fact I have not thought about any further cases. Since you're not
giving full examples, I can only guess what you mean: The cases in the
attachment are working as expected. Anything else?

Cheers,
Janus




> On Wed, 9 Nov 2016 21:42:15 +0100
> Janus Weil <janus@gcc.gnu.org> wrote:
>
>> Hi all,
>>
>> I have committed yet another obvious ice-on-invalid fix:
>>
>> https://gcc.gnu.org/viewcvs?rev=242020&root=gcc&view=rev
>>
>> Cheers,
>> Janus
>
>
> --
> Andre Vehreschild * Email: vehre ad gmx dot de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: andre.f90
Type: text/x-fortran
Size: 194 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/fortran/attachments/20161110/3e4be687/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: andre2.f90
Type: text/x-fortran
Size: 187 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/fortran/attachments/20161110/3e4be687/attachment-0001.bin>