[Patch, Fortran, pr70397, gcc-5, v1] [5/6 Regression] ice while allocating ultimate polymorphic
Andre Vehreschild
vehre@gmx.de
Mon Mar 28 16:31:00 GMT 2016
Hi Paul,
thanks for the quick review. Committed to gcc-5-branch as r234507. The
patch for trunk needs more polishing than expected. I hope to present
it soon.
Regards,
Andre
On Sun, 27 Mar 2016 19:19:11 +0200
Paul Richard Thomas <paul.richard.thomas@gmail.com> wrote:
> Hi Andre,
>
> The patch looks to be fine to me for both trunk and 5-branch.
>
> Thanks for the patch.
>
> Paul
>
> On 27 March 2016 at 18:53, Andre Vehreschild <vehre@gmx.de> wrote:
> > Hi all,
> >
> > and here is already the follow-up. In the initial patch a safe wasn't commenced
> > before pulling the patch, which lead to a refactoring of the new functions node
> > to be partial only. Sorry for the noise.
> >
> > - Andre
> >
> > Am Sun, 27 Mar 2016 18:49:18 +0200
> > schrieb Andre Vehreschild <vehre@gmx.de>:
> >
> >> Hi all,
> >>
> >> attached is a patch to fix an ICE on allocating an unlimited polymorphic
> >> entity from a non-poly class or type without an length component. The routine
> >> gfc_copy_class_to_class() assumed that both the source and destination
> >> object's type is unlimited polymorphic, but in this case it is true for the
> >> destination only, which made gfortran look for a non-existent _len component
> >> in the source object and therefore ICE. This is fixed by the patch by adding
> >> a function to return either the _len component, when it exists, or a constant
> >> zero node to init the destination object's _len component with.
> >>
> >> Bootstrapped and regtested ok on x86_64-linux-gnu/F23. (Might have some
> >> line deltas, because my git is a bit older. Sorry, only have limited/slow
> >> net-access currently.)
> >>
> >> The same patch should be adaptable to trunk. To come...
> >>
> >> Ok for 5-trunk?
> >>
> >> Regards,
> >> Andre
> >
> >
> >
--
Andre Vehreschild * Email: vehre ad gmx dot de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: submit.diff
Type: text/x-patch
Size: 5492 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/fortran/attachments/20160328/e69cd19f/attachment.bin>
More information about the Fortran
mailing list