[Fortran, Patch, PR72698, v1] [5/6/7 Regression] ICE in lhd_incomplete_type_error, at langhooks.c:205

[Andre Vehreschild]

Hi Thomas,

thanks for the review. I have changed the test to run and result check
as requested. Committed to trunk as r239236.

Will commit to gcc-6 and -5-branch in one week.

Regards,
	Andre

On Mon, 8 Aug 2016 08:42:08 +0200
Thomas Koenig <tkoenig@netcologne.de> wrote:

> Am 07.08.2016 um 13:52 schrieb Andre Vehreschild:
> Hi Andre,
> 
> > attached patch fixes the ICE caused by a zero-sized string.
> > Assigning that string to a temporary variable obviously did not
> > work out. The patch fixes this by checking for zero-sized strings
> > in SOURCE= and not producing the code to assign "nothing" to the
> > temporary variable and later to the allocated memory. The version
> > for gcc-5 had to be adapted slightly, because the version of the
> > ALLOCATE() implementation is way behind.
> >
> > Bootstrapped and regtested on x86_64-linux-gnu/F23. Ok for trunk,
> > gcc-6 and gcc-5?  
> 
> Looks good.
> 
> With the test case, you might consider changing that into a runtime
> test to make sure that the correct result is obtained.
> 
> So, OK with that change.
> 
> Regards
> 
> 	Thomas
> 


-- 
Andre Vehreschild * Email: vehre ad gmx dot de 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: submit.diff
Type: text/x-patch
Size: 3289 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/fortran/attachments/20160808/0c985ff4/attachment.bin>