PR fortran/44054 Convert all gfc_error_1 calls to gfc_error

[Mikael Morin]

Le 17/05/2015 20:22, Manuel López-Ibáñez a écrit :
> Hi,
> 
> This patch finishes the conversion of Fortran diagnostics to use the
> common diagnostics by removing all gfc_error*_1 variants.
> 
> I noticed that whether some buffered gfc_error_1() end up printed may
> depend on whether a gfc_error_now is given or not, and not only on
> whether there is any output buffered. Thus, I reintroduced a new
> error_buffer of type gfc_buffer_error.
> 
> The rest is mostly mechanic.
> 
> I did not make an attempt in this patch to remove all code that has
> become obsolete now:
> 
> gfc_get_terminal_width (already implemented in diagnostics.c)
> error_char (already empty, but used by other obsolete functions)
> error_string (obsolete, just use %s)
> error_uinteger (obsolete, just use %lu)
> error_integer (obsolete, just use %ld)
> gfc_widechar_display_length, gfc_wide_display_length,
> print_wide_char_into_buffer, gfc_print_wide_char (I'm not sure how
> this functionality differs from what the common diagnostics already
> do, perhaps some of it should be moved to the common code)
> show_locus (obsolete, except "Included at" handling should be moved to
> the common diagnostics, no testcase is testing this).
> show_loci (obsolete, except "During initialization" handling should be
> moved to the common diagnostics, no testcase is testing this)
> error_print, error_printf (obsolete)
> 
> Bootstrapped and regression tested on x86_64-linux-gnu.
> 
> OK?
> 
Looks good to me.  Thanks.

Mikael