[PATCH] fortran/66106 -- Enforce C1202 from F2008

FX fxcoudert@gmail.com
Fri May 15 15:46:00 GMT 2015


 - You’re missing the match.c part of the patch (I really had a hard time figuring out how the patch was supposed to work! then I read the one posted in the PR)
 - Let’s avoid the strcmp() string comparison and use “op == INTRINSIC_NONE” as the condition (seems clearer and more efficient to me)
 - Maybe not doing all the tests (those after "The following if-statements”) if op == INTRINSIC_NONE, as all the s2 comparisons will be false.
 - The PR number in the ChangeLog is wrong (both times)

With the above fixed, it’s OK.
Thanks for taking care of all this!

FX



More information about the Fortran mailing list