[Patch, fortran] Cosmetics: Dup. code removal, indent fix, typo fix.

[Andre Vehreschild]

Hi Jerry,

thanks for the review. Committed as r220345.

Regards,
	Andre

On Sat, 31 Jan 2015 07:41:24 -0800
Jerry DeLisle <jvdelisle@charter.net> wrote:

> On 01/30/2015 04:10 AM, Andre Vehreschild wrote:
> > Hi all,
> >
> > I fear this fix is not so obvious in one location, I therefore ask for a
> > review. The attached patch fixes:
> >
> > - a duplicate code fragment (possibly due to merged twice),
> > - the indentation in the trans-expr.c block (in my first patch), and
> > - a typo on the datatype-size to create for the charlen.
> >
> > The length of a char-array is stored as a 4-byte BT_INTEGER. Due to a typo a
> > 1-byte BT_INTEGER was requested. The patch fixes this. I know this patch
> > mixes several trivial issues. Should I do separate patches for each of
> > them, or what is the most desirable method?
> >
> 
> Cosmetic things are OK to throw in the mix as long as you have the Changelog. 
> Duplicate code removal is just about as obvious as one can get. No need for 
> separate patches.
> 
> > Bootstraps and regtests ok on x86_64-linux-gnu/FC20.
> >
> 
> I have learned the hard way that if you forget the testing even on trivial 
> things it can byte you.  OK to commit!  Thanks.


-- 
Andre Vehreschild * Email: vehre ad gmx dot de 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cosmetic_2_final.patch
Type: text/x-patch
Size: 3087 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/fortran/attachments/20150202/0b9c72bb/attachment.bin>