[Ping, Patch, Fortran] Prevent segfault with dump-*-original for implicit class expressions.

Andre Vehreschild vehre@gmx.de
Fri Apr 24 08:32:00 GMT 2015


Ping!

This ICE is still in gfortran and with it the patch still current. 

Bootstrapped and regtests ok on x86_64-linux-gnu/F21.

The patch has only changed in being applyable on current trunk (ct) w/o big
shifts.

Ok for trunk?

- Andre

This crash is still current 
On Fri, 13 Mar 2015 11:33:39 +0100
Andre Vehreschild <vehre@gmx.de> wrote:

> Hi all,
> 
> this is another patch preventing a segfault. This time the segfault occurred,
> when -fdump-(fortran|tree)-original was given with the program having an
> implicit class set. The issue is that the _data component is assumed to be
> present in a BT_CLASS w/o checking and trying to access the unlimited
> polymorphic flag there. The patch fixes this by redirecting the access to the
> flag to the correct position whether the _data component is present or not.
> 
> Building a testcase for this is difficult for me. May be I am just blocked in
> the head there. The issue occurred when trying to dump the
> (fortran|tree)-original of the testcase gfortran.dg/implicit_class_1.f90. So
> one could argue to add the flag to that testcase, but does it pay in contrast
> to the additional effort each time the testsuite is executed? I have added the
> test now, not being happy with it, but having no clue how to do it better.
> 
> Bootstraps and regtests ok on x86_64-linux-gnu/F20.
> 
> Ok, for trunk?
> 
> Regards,
> 	Andre


-- 
Andre Vehreschild * Email: vehre ad gmx dot de 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: crashfix2_v1.clog
Type: application/octet-stream
Size: 481 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/fortran/attachments/20150424/3120a05f/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: crashfix2_v1_ct.patch
Type: text/x-patch
Size: 3671 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/fortran/attachments/20150424/3120a05f/attachment.bin>


More information about the Fortran mailing list