[Patch, Fortran] Component declarations overwrite types of Cray Pointee variables
Tobias Burnus
burnus@net-b.de
Wed Sep 3 18:50:00 GMT 2014
Fritz Reese wrote:
> The typespecs for Cray pointees are overwritten by the typespecs of
> components with the same name which are declared later.
> Here is a proposed patch from 4.8.3 (test case comments/ChangeLog
> descriptions are updated from the submission on bugzilla). The test
> case demonstrates the problem.
OK. Thanks for the patch. I have committed it as Rev. 214891.
> FYI, I am currently working with my employer so any future changes I
> have can comply with GNU's legal requirements.
That would be useful. In terms of complexity and number of line changes
of the actual code, I think it still counts as "trivial" such that I
have committed the patch without waiting for the copyright assignment.
> Also my mail client replaces tabs with spaces so I'm sorry for any whitespace issues.
An alternative would be to attach the patch â possibly such that the
mail client uses "text/*" as MIME code (e.g. using ".txt" as suffix,
though several programs also handle other extensions). That way it shows
up as text in most email programs and in the mail archive as text.
> 2014-09-02 Fritz Reese <Reese-Fritz@zai.com>
>
> PR fortran/62174
> * gcc/testsuite/gfortran.dg/cray_pointers_11.f90: New.
Two nits: I'd prefer if you placed both changelogs before the actual
patch - not between different parts of the patch. And entries in
ChangeLog files are relative to the file, i.e. in this case
"gfortran.dg/..." instead of "gcc/testsuite/gfortran.dg/...".
Tobias
More information about the Fortran
mailing list