[FORTRAN PATCH] Quash two -Wlogical-not-parentheses warnings
Marek Polacek
polacek@redhat.com
Mon Sep 1 13:23:00 GMT 2014
These two issues are the last ones blocking moving -Wlogical-not-parentheses
to -Wall. I tried to fix them, but my attempts failed, so I opened
PR62270. I hope we could for now go with the following; it only quiets
the warning, but otherwise does not change the code. Hopefully someone
familiar with the Fortran codebase will take a look at that PR...
2014-09-01 Marek Polacek <polacek@redhat.com>
* interface.c (compare_parameter): Wrap LHS of a comparison in parens.
* trans-expr.c (gfc_conv_procedure_call): Likewise.
diff --git gcc/fortran/interface.c gcc/fortran/interface.c
index b210d18..68d8545 100644
--- gcc/fortran/interface.c
+++ gcc/fortran/interface.c
@@ -2014,7 +2014,7 @@ compare_parameter (gfc_symbol *formal, gfc_expr *actual,
if (formal->ts.type == BT_CLASS && formal->attr.class_ok
&& actual->expr_type != EXPR_NULL
&& ((CLASS_DATA (formal)->attr.class_pointer
- && !formal->attr.intent == INTENT_IN)
+ && (!formal->attr.intent) == INTENT_IN)
|| CLASS_DATA (formal)->attr.allocatable))
{
if (actual->ts.type != BT_CLASS)
diff --git gcc/fortran/trans-expr.c gcc/fortran/trans-expr.c
index f2ed474..6592c7e 100644
--- gcc/fortran/trans-expr.c
+++ gcc/fortran/trans-expr.c
@@ -4589,7 +4589,7 @@ gfc_conv_procedure_call (gfc_se * se, gfc_symbol * sym,
&& e->expr_type == EXPR_VARIABLE
&& (!e->ref
|| (e->ref->type == REF_ARRAY
- && !e->ref->u.ar.type != AR_FULL))
+ && (!e->ref->u.ar.type) != AR_FULL))
&& e->symtree->n.sym->attr.optional)
{
tmp = fold_build3_loc (input_location, COND_EXPR,
Marek
More information about the Fortran
mailing list