PR 60414: Patch proposal
FX
fxcoudert@gmail.com
Fri Jul 18 22:12:00 GMT 2014
Hi Andre, and welcome aboard!
The explanation you give is nice, your patch submission looks clean. Two things:
1. Do you have a copyright assignment on file with the FSF? See https://gcc.gnu.org/contribute.html
2. Normally, all GCC patch submissions should be accompanied by a statement saying how you tested the patch. The standard thing to do is to check that the patched sources still bootstrap and that there is no regression in the testsuite. This can be stated as “Patch bootstrapped and regtested on <insert here your testing platform triplet, like x86_64-apple-darwin13>”. In that particular case, it might also be nice to indicate that not only the testcase doesn’t crash the compiler any more, but to confirm that it now generates the correct code (i.e. that we don’t turn an ice-on-valid bug into a wrong-code bug!).
Cheers,
FX
More information about the Fortran
mailing list