[PATCH 5/6] [GOMP4] OpenACC 1.0+ support in fortran front-end

[Ilmir Usmanov]

Hi Thomas!

On 10.02.2014 12:52, Thomas Schwinge wrote:
> --- /dev/null
> +++ b/gcc/testsuite/gfortran.dg/goacc/goacc.exp
> @@ -0,0 +1,36 @@
> +# Load support procs.
> +load_lib gfortran-dg.exp
> +
> +if ![check_effective_target_fopenmp] {
> +  return
> +}
>> I assume that this should be indeed "fopenmp" here and not "fopenacc" as
>> both share libgomp?
> It should be fopenacc, because it tests whether the compiler accepts
> -fopenacc.
My bad. I've missed the fact that you use 
check_effective_target_fopenacc in gcc.gd/goacc/goacc.exp.
>
>>> +# Main loop.
>>> +gfortran-dg-runtest [lsort \
>>> +       [find $srcdir/$subdir *.\[fF\]{,90,95,03,08} ] ] " -fopenacc -fdump-parse-tree"
>> As you use -fopenacc here, you probably can get rid of it in dg-options.
> Right.
>
>> Can't you? I am not sure whether -fdump-parse-tree is needed; on the
>> other hand, it just clutters the *log files.
> Yes, I think that should just be in the test case files that actually
> need it?
I've also missed this, will fix.

I think, we need GENERIC nodes checks right now since the implementation 
is "up to GENERIC". However, in future, when back-end will be 
implemented, we can remove them.

-- 
Regards,
Ilmir.