[PATCH] Add an AUTOMATIC statement for use with -fno-automatic.

Steve Kargl sgk@troutmask.apl.washington.edu
Mon Feb 3 04:34:00 GMT 2014


On Sun, Feb 02, 2014 at 11:58:37AM +0100, Janus Weil wrote:
> 
> some comments (without actually looking at your patch in detail):
> 
> 1) There were some comments to your previous inquiry about AUTOMATIC
> on this list, which you did not reply to properly.
> 
> 2) You will need to have a copyright assignment on file with the FSF
> before contributing code to GCC.
> 
> 3) You will need to supply a couple of test cases to demonstrate that
> the patch actually works as advertised. Those would go into
> gcc/testsuite/gfortran.dg/.
> 
> 4) Have you checked the patch for testsuite regressions ("make check-gfortran")?
> 
> 5) The AUTOMATIC should only be accepted with -std=legacy or -std=gnu.
> That is what 'gfc_notify_std' is for. AFAICS, you currently only use
> this to allow duplicate specifications of AUTOMATIC, but not to reject
> the AUTOMATIC keyword at all.
> 
> 6) One could take the position that you should rather fix your code to
> comply with the Fortran standard instead of introducing non-standard
> extensions into the compiler. One could also object to introducing a
> language element that is only in effect with certain compiler options.
> Can you convince us why this is absolutely necessary?
> 

7) Documentation.  gfortran.info includes a section on
supported extension.

-- 
steve



More information about the Fortran mailing list