[patch, fortran] PR Detect same values in vector expression subscripts

Thomas Koenig tkoenig@netcologne.de
Sun Jul 28 21:15:00 GMT 2013


Hi Tobias and Mikael,

 > Something went wrong with the indentation of the last two lines.

Fixed.

 > Additionally: How about simply returning with an "return false;"?

After some more thinking, I used the option that you suggested.  We'll
see if we get feedback from users who want something else, if any :-)

> I think it should be:
>> >	for (i = 0; i < GFC_MAX_DIMENSIONS; i++)

Fixed with

+       for (i = 0; i < GFC_MAX_DIMENSIONS
+              && ref->u.ar.dimen_type[i] != 0; i++)

(I didn't want to loop over all dimensions unconditially).
I also updated the test case to reflect this.

Commit is at http://gcc.gnu.org/viewcvs?rev=201294&root=gcc&view=rev .

Thanks a lot for the reviews!

	Thomas




More information about the Fortran mailing list