Many regressions with: [patch] Cleanup fortran/convert.c

[Tobias Burnus]

Steven Bosscher wrote:
> This cleans up some remnants of the ancestors of fortran's convert.c,
> which was copied from GNAT IIRC. I would bootstrap&test this, but trunk appears to be broken for x86_64-linux right now (ICE in patch_jump_insn). But I can post this
> for review, at least.
> OK for trunk, after bootstrap+test?

Your patch seems to have caused many Fortran regressions. At least I see 
with 185156 only one (known) failure, cf. 
http://gcc.gnu.org/ml/gcc-testresults/2012-03/msg01069.html

While starting with 185160 there are many, many gfortran failures, cf. 
http://gcc.gnu.org/ml/gcc-testresults/2012-03/msg01073.html

Tobias


> 	* Make-lang.in (convert.o): Depend on convert.h.
> 	* convert.c: Header and comment cleanups.
> 	(gfc_thruthvalue_conversion): Rename static function
> 	to truthvalue_conversion.  Do not use 'internal_error' from here,
> 	use 'gcc_unreachable' instead.
> 	(convert): Do not use 'error' for conversions to void, use
> 	'gcc_unreachable' instead.  Likewise for conversions to non-scalar
> 	types.  Do not hanlde ENUMERAL_TYPE, the front end never creates them.
> 	Clean up #if 0 code.