[patch, fortran] Warning for feal / complex equality / inequality comparisons

Thomas Koenig tkoenig@netcologne.de
Sun Aug 19 15:07:00 GMT 2012


Hi Tobias,

> Can you move up the comment before the "(op1->ts.type"? When reading the
> patch, I stumbled over that, before reading 8 lines later that checking
> op1 is sufficient.

> Additionally, your gfc_warning is rather unfriendly to translators (try
> yourself to translate it, taking into account that the "Equality" string
> might be re-used elsewhere). I think it is better to have two separate
> strings, one for equality and one for inequality.

Committed as rev. 190516 with the fixes you suggested.  The version
of the patch I committed is attached.

Thanks a lot!

	Thomas


-------------- next part --------------
A non-text attachment was scrubbed...
Name: p3.diff
Type: text/x-patch
Size: 4756 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/fortran/attachments/20120819/e50eb5f7/attachment.bin>


More information about the Fortran mailing list