[fortran, patches] Two short patches to review

FX fxcoudert@gmail.com
Tue Nov 8 23:57:00 GMT 2011


>> -- 50404: refuse to have a CLOSE statement without a UNIT
>> (F2008's C908 "A file-unit-number shall be specified in a
>> close-spec-list") (http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50404)
> 
> jerry already approved this one.

And I committed it as rev. , with a slight modification to add a decent locus (otherwise, the current locus is at a totally wrong place) and a testcase. Committed patch is attached.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: close.diff
Type: application/octet-stream
Size: 2559 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/fortran/attachments/20111108/5d28ca21/attachment.obj>
-------------- next part --------------



>> -- 50540: issue a normal error instead of an internal error, in
>> conditions that could reasonably be triggered by invalid code
>> (http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50540)
> 
> Given that you've read the patch and my comments in the PR,
> and that you've contributed/reviewed/committed hundreds of
> patches, I think that this is sufficient review.  I certainly
> have no problems with committing the patch.

Well, given the amount of compliment, I'm sure to screw up and then hide :)
I'll get to it tomorrow morning, after some sleep.

Thanks,
FX


More information about the Fortran mailing list