[Patch, fortran] PR45743 - [4.6 Regression] gfortran.dg/whole_file_3.f90 ICE: verify_stmts failed: invalid conversion in gimple call with -finline-small-functions

[Paul Richard Thomas]

Thanks, Steve.

Paul

On Tue, Feb 22, 2011 at 8:51 PM, Steve Kargl
<sgk@troutmask.apl.washington.edu> wrote:
> On Tue, Feb 22, 2011 at 08:15:31PM +0100, Paul Richard Thomas wrote:
>> This patch fixes the regression in this PR.  Frankly, I think that
>> fixing the warning versus error issue on an obsolescent language
>> feature is a waste of effort.  For me it is a WONTFIX.  That said, the
>> invalid conversion in gimple is fundamental.  It comes about because,
>> in the testcase, the procedure 'r' is passed as an actual argument to
>> 'phload' without otherwise being referenced in the main program.  This
>> means that two different declarations are floating around for the
>> actual and formal arguments, which clash during inlining.  The most
>> economic fix here is to not try to inline such procedures :-)
>> Undoubtedly, the actual and formal arguments could be connected but
>> this really seems more trouble than it is worth for a procedure
>> without an explicit interface.
>>
>> Bootstrapped and regtested on Ubuntu-10.1/i686 - OK for trunk?
>>
>
> OK.
>
> PS: FWIW, I agree with yout WONTFIX assessment.
>
> --
> Steve
>



-- 
The knack of flying is learning how to throw yourself at the ground and miss.
       --Hitchhikers Guide to the Galaxy