[Patch,Fortran testsuite, committed] Fix dg-do in the test suite

Tobias Burnus tobias.burnus@physik.fu-berlin.de
Tue Feb 22 10:11:00 GMT 2011


Hi all,

this patch is based on the remark of Jerry that there are some
bug in the "dg-do" in the test suite.

The attached patch (committed) fixes all those which I found,
except for:

- fmt_f0_1.f90, which Jerry found and which fails
  cf. http://gcc.gnu.org/ml/fortran/2011-02/msg00216.html

- allocate_deferred_char_scalar_1.f03
  which fails and is now PR 47846

As the testsuite defaults to "dg-do compile", only the "dg-do run"
changes are important. Note: Besides the braces and lacking
spaces also writing "run" in quotation marks does not work.

Regtested on x86-64-linux
and committed (Rev. 170393) as obvious.

Thanks to Jerry for pointing out the issue!

Jerry wrote:
> I am working on the bad test case, but I think we need to
> fix the testsuite drivers to fail on this sort of typo.

Well, the only way it to make a lacking dg-do failing instead
of defaulting to compile. Additionally, it helps to run
newly added tests separately before submittal as this increases
the chance that one finds such issues.

Tobias

PS: I think there might be more issues, I only did some grepping.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: testcase-fix2.diff
Type: text/x-diff
Size: 22828 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/fortran/attachments/20110222/30bf0120/attachment.bin>


More information about the Fortran mailing list