[Patch, fortran] Would this patch - applied to trunk - be OK for the 4.6 branch ?

Toon Moene toon@moene.org
Thu Dec 22 19:25:00 GMT 2011


On 12/21/2011 10:00 PM, Steve Kargl wrote:

> On Mon, Dec 19, 2011 at 06:54:08PM +0100, Toon Moene wrote:

>> The attached patch makes -finit-<type>=<constant>  generate default
>> initialization for automatic arrays.
>>
>> It was OK for the trunk - is it also OK for the 4.6 branch ?
>>
>> Strictly speaking, it doesn't fix a regression, it is a fix for a
>> (non-default) debugging option.

> Speaking for myself, it seems that the general rule
> of thumb among the gfortran committers is that it
> is up to the discretion of the committer if he/she
> wants to backport a non-regression patch.  The 2
> measures I use are: 1) is the patch fairly local
> (ie., only a few lines in at most a couple of files);
> 2) what is the likelihood for causing a problem
> (ie., a regression of breaking bootstrap).
>
> In your particular case, I think the patch is a
> useful debugging aid, and the likelihood of causing
> a problem is very low.

Yep, I thought so too - however, it has been over 6 years since I 
contributed a code patch, so I wanted to be careful.

It is committed as revision 182634.

Thanks for your comment.

-- 
Toon Moene - e-mail: toon@moene.org - phone: +31 346 214290
Saturnushof 14, 3738 XG  Maartensdijk, The Netherlands
At home: http://moene.org/~toon/; weather: http://moene.org/~hirlam/
Progress of GNU Fortran: http://gcc.gnu.org/wiki/GFortran#news



More information about the Fortran mailing list