[Patch, fortran] PR fortran/50071 Duplicate statement labels from different scoping units rejected.
Mikael Morin
mikael.morin@sfr.fr
Thu Aug 18 22:55:00 GMT 2011
On Wednesday 17 August 2011 00:05:57 Tobias Burnus wrote:
> > I can propose the following ad-hoc fix for the two latter cases.
> >
> > The patch passes gfortran.dg/*goto* and gfortran.dg/*label*, and I'm
> > doing a full regression test. Is that OK?
>
> That's OK with test cases (original issue plus the two newly fixed
> ones). Nit: You have a missing tab at:
[...]
I committed the first patch as revision 177882 and the second one with
testcases and the space nit fixed as revision 177885 (diff attached).
>
> > About your two former cases, the first one looks especially tricky. For
> > the second one, it may be valid, but a warning would be nice IMO as one
> > of the labels is masked by the other. Both cases need more investigation
> > anyway.
>
> I think those could be deferred. - If you don't work on them, one should
> fill a PR to make sure they do not get forgotten.
>
You have already added them as comments to PR 50071, but I will make separate
PRs for them.
Mikael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: r177885.diff
Type: text/x-patch
Size: 5619 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/fortran/attachments/20110818/871c50d7/attachment.bin>
More information about the Fortran
mailing list