[Patch, Fortran] (Coarray) Fix constraint checks for LOCK_TYPE

Tobias Burnus burnus@net-b.de
Wed Aug 17 22:50:00 GMT 2011


On 05 August 2011 16:42, Mikael Morin wrote:
> OK, I played a bit myself to see what the "right way" would look like, and I
> came up with the attached patch, which is complicated, and not even correct.
> And indeed, it plays with allocatable and pointer stuff.
> So your approach makes some sense now.
>
> I do here some propositions for comment and error messages which IMO explain
> better where the problem lies (Iff I have understood the problem correctly).
> They are quite verbose however, and possibly not correct english (many
> negations).

Thanks for reviewing the patch and for the suggestions!

Attached is an updated version of the patch, I hope it is now better, 
though I think there is still room for improvement.

Changes:
- coarray_lock_5.f90: Added subroutine test2 with several additional 
test cases
- updated dg-error
- parse.c's parse_derived: Add one comment, updated all error texts, 
fixed codimension -> coarray_comp bug, added missing check and split 
some of the checks into LOCK_TYPE and lock_comp.

Build and regtested on x86-64-linux.
OK - or suggestions how to improve it further?

Tobias
-------------- next part --------------
A non-text attachment was scrubbed...
Name: lock-check-v3.diff
Type: text/x-patch
Size: 14057 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/fortran/attachments/20110817/7ca3d056/attachment.bin>


More information about the Fortran mailing list