[Patch, fortran] [0/11] Inline transpose part 1
Mikael Morin
mikael.morin@sfr.fr
Sat Sep 11 10:22:00 GMT 2010
On Wednesday 08 September 2010 21:23:07 Thomas Koenig wrote:
> Hello Mikael,
>
> > The good thing:
> > With the patches transpose(a+b) is handled without a
temporary for (a +
> > b).
> >
> > The bad thing:
> > With the patches function(transpose(a)) needs a temporary for
> > transpose(a) which was not needed before. This is due to the
trans stage
> > trick which is gone, and will have to come back save us in
> > gfc_conv_expr_descriptor: this is the point of the inline
transpose part
> > 2 patch serie (to come).
>
> The patchset is OK. Thanks a lot for the patches!
>
> Please do the second part before 4.6 comes out to avoid a
regression.
>
> Also, I would recommend removing the transpose* functions
from the
> fortran-dev branch once these patches have been committed
there.
>
> Would it make sense to have a PR for both cases, to make sure
they
> aren't forgotten?
>
> Best regards
>
> Thomas
For information the commit revisions were :
1/11: 164087
2/11: 164090
3/11: 164094
4/11: 164103
5/11: 164109
6/11: 164112
7/11: 164158
8/11: 164162
9/11: 164169
10/11: 164205
11/11: 164205
I opened http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45648 for the
regression introduced and will add an entry to remove transpose
intrinsic in http://gcc.gnu.org/wiki/LibgfortranAbiCleanup once I have
figured out how to dot it.
Thanks for the review.
Mikael
More information about the Fortran
mailing list