[patch, libgfortran] PR43899 Wrong unused-variable warning with NAMELISTs

[Janne Blomqvist]

On Wed, Nov 3, 2010 at 07:39, Jerry DeLisle <jvdelisle@frontier.com> wrote:
> 2010-11-02  Jerry DeLisle  <jvdelisle@gcc.gnu.org>
>
>        PR libgfortran/43899
>        * runtime/error.c (generate_error): New function to generate a run
>        time warning message. Fix some whitespace.

generate_warning, not generate_error. The comment above the function
in the patch also suffers from the same problem. Also, the iexport()
line should be removed (see below).

>        * gfortran.map: Add symbol for new function.

Please remove this. We don't need to export generate_warning, as it's
never called from outside the library.

If at some point in the future we need to do that, it can be exported then.

>        * libgfortran.h: Add prototype for new function.

Due to the above, should be marked with internal_proto() instead of
iexport_proto().


Otherwise the patch looks good. Ok for trunk with the above changes.

-- 
Janne Blomqvist