[patch, fortran] PR fortran/36928 - array dependencies
Thomas Koenig
tkoenig@netcologne.de
Mon May 31 20:26:00 GMT 2010
Tobias Burnus wrote:
> You should add a short comment on the algorithm thus one can quickly
> check it, e.g.
> "No dependency if reminder of (l_start - r_start)/gcd(l_stride,
> r_stride)) is nonzero."
> At least it took me a short while to translate the GMP functions into
> the string above.
>
> (Additionally, I felt better, if you would add a run-test and include
> also some checks that the temporary is still generated in some commen
> cases. I am always worrying that on introduces bugs in such cases.)
I introduced some correctness checks in an additional test case (see
below).
> > Regression-tested on x86_64-unknown-linux-gnu. OK for trunk?
> >
> OK with considering the nit above.
Waiting for Emacs...
Sende fortran/ChangeLog
Sende fortran/dependency.c
Sende testsuite/ChangeLog
Hinzufügen testsuite/gfortran.dg/array_assignment_1.F90
Hinzufügen testsuite/gfortran.dg/dependency_27.f90
Ãbertrage Daten .....
Revision 160085 übertragen.
Here's what I committed.
Thanks for the review!
Thomas
2010-05-31 Thomas Koenig <tkoenig@gcc.gnu.org>
PR fortran/36928
* dependency.c (gfc_check_section_vs_section): Check
for interleaving array assignments without conflicts.
2010-05-31 Thomas Koenig <tkoenig@gcc.gnu.org>
PR fortran/36928
* gfortran.dg/dependency_27.f90: New test.
* gfortran.dg/array_assign_1.F90: New test.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dependency_27.f90
Type: text/x-fortran
Size: 333 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/fortran/attachments/20100531/50c2f4ea/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: array_assignment_1.F90
Type: text/x-fortran
Size: 1244 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/fortran/attachments/20100531/50c2f4ea/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pr36928-2.diff
Type: text/x-patch
Size: 1425 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/fortran/attachments/20100531/50c2f4ea/attachment-0002.bin>
More information about the Fortran
mailing list