[PATCH] PR fortran/44346 -- check some values in ibits, mvbits

[Steve Kargl]

On Mon, May 31, 2010 at 08:04:48PM -0700, Steve Kargl wrote:
> On Mon, May 31, 2010 at 06:51:58PM -0700, Jerry DeLisle wrote:
> > On 05/31/2010 01:34 PM, Steve Kargl wrote:
> > >The attached patch was tested on i686-*-freebsd.  The patch with
> > >the testcases are obvious (to at least me).
> > >
> > >OK for trunk (and 4.5 after testing)?.
> > >
> > OK, thanks much.
> > 
> 
> I have a better patch, which I'll post later tonight.
> It deals with btest, ibclr, ibits, ibset, and mvbits.
> 

The better patch is attached.  Is this ok for
trunk (and 4.5 after testing).

2010-06-01  Steven G. Kargl  <kargl@gcc.gnu.org>

	* testsuite/gfortran.dg/mvbits_9.f90: New test.
	* testsuite/gfortran.dg/ibset_1.f90: Ditto.
	* testsuite/gfortran.dg/ibits_1.f90: Ditto.
	* testsuite/gfortran.dg/btest_1.f90: Ditto.
	* testsuite/gfortran.dg/ibclr_1.f90: Ditto.

2010-06-01  Steven G. Kargl  <kargl@gcc.gnu.org>

	* fortran/intrinsic.c (add_functions): Change gfc_check_btest,
	gfc_check_ibclr, and gfc_check_ibset to gfc_check_bitfcn.
	* fortran/intrinsic.h: Remove prototypes for gfc_check_btest,
	gfc_check_ibclr, and gfc_check_ibset.  Add prototype for
	gfc_check_bitfcn.
	* fortran/check.c (nonnegative_check, less_than_bitsize1, 
	less_than_bitsize2): New functions.
	(gfc_check_btest): Renamed to gfc_check_bitfcn.  Use
	nonnegative_check and less_than_bitsize1.
	(gfc_check_ibclr, gfc_check_ibset): Removed.
	(gfc_check_ibits,gfc_check_mvbits): Use nonnegative_check and
	less_than_bitsize1.

-- 
Steve
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bitfcn.diff
Type: text/x-diff
Size: 10407 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/fortran/attachments/20100601/963f392d/attachment.bin>