[Patch, Fortran] PR 40849 - fix %-handling for gettext (was: Re: PRs 41872, 40849, 40849, 42517)
Tobias Burnus
burnus@net-b.de
Mon Jan 4 07:42:00 GMT 2010
Steve Kargl wrote:
> On Wed, Dec 30, 2009 at 10:20:44PM +0100, Tobias Burnus wrote:
>
>> attached you find a patch which fixes a larger and several smaller issues.
>>
Thanks Steve for the review! I have now committed the approved patches.
>> b) PR 40849 - Improve % checking for msgfmt
>>
> This part looks like a mechanical change, but I'm not familiar
> with the NLS stuff. So, I'll let others comment out it.
>
Attached is the remaining patch. I wrote:
>> Currently, all gfortran strings to gfc_error etc. are marked as
>> no-c-format; thus "msgfmt" does not check whether the original string
>> and the translated string contain the same items; if one mixes up e.g.
>> %s and %d then one gets a crash.
>> One cannot mark those as "c-format" as %L is invalid. However, similarly
>> to gcc/* one can mark them as something else, e.g. as
>> "gcc-internal-format". That's what the patch does.
Tobias
-------------- next part --------------
A non-text attachment was scrubbed...
Name: error.diff
Type: text/x-patch
Size: 4276 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/fortran/attachments/20100104/2a203829/attachment.bin>
More information about the Fortran
mailing list