[PATCH] Fix up Fortran line numbers (PR fortran/45186)

Tobias Burnus burnus@net-b.de
Mon Aug 16 21:18:00 GMT 2010


  Jakub Jelinek wrote:
> As discussed on IRC and in the PR, this patch fixes Fortran line info
> by basically going back to what GCC 4.4 did.  The FE doesn't pass
> input_location to all the various build*/fold_build*/build*_v
> functions/macros when it creates the trees, there are more than 1000
> of such places.
>
> Ok for 4.5 (for which changing those 1000 places isn't really desirable)?
> What about 4.6?
> Bootstrapped/regtested on x86_64-linux and i686-linux.

OK for 4.5.

For 4.6 I think one should really consider changing the 700-odd 
fold_build* to fold_build*_loc; for the build* (and build*_v) calls, I 
have to figure out (a) whether is is needed to add the locus and (b) if 
so, how to do this - there are no build*_loc functions. I fear we won't 
do the _loc fix if one commits your patch to the 4.6 trunk.

Thanks for the patch!

Tobias



More information about the Fortran mailing list