[Patch, libfortran] Split io.h into multiple include files
Jerry DeLisle
jvdelisle@verizon.net
Mon Nov 2 02:20:00 GMT 2009
On 11/01/2009 05:48 PM, Steve Kargl wrote:
> On Sun, Nov 01, 2009 at 05:13:35PM -0800, Jerry DeLisle wrote:
>> On 10/30/2009 04:20 PM, Janne Blomqvist wrote:
>>> Hi,
>>>
>>> the attached patch splits io.h into multiple include files such that a
>>> few of the components of the I/O library now have their own header
>>> files. This makes it easier to get a grip on the structure, makes
>>> dependencies between components slightly easier to grasp, and reduces
>>> the compilation cascade if one edits one of the new lower level
>>> headers. Regtested on x86_64-unknown-linux-gnu, Ok for trunk?
>>>
>> Not all that necessary but I have no preferences. OK
>>
>
> Jerry,
>
> I was going to let you weigh in on this patch because you
> and Janne are the 2 (along with Thomas) that do the most
> work in libgfortran. I'll, however, state that I support
> Jannei's attempt to make the headers a little more sane.
> I've thought about break up gfortran.h, but haven't acted
> about that urge.
>
I see the advantages. They were broken up somewhat once before. I really am OK
with it.
There are some BOZ buffer constants in libgfortran.h that ought to be in io.h
and the gfc_xtoa is in error.c and it ought to be in write.c
The prototype is in libgfortran.h because the routine is shared between error.c
and write.c. Maybe we need a utility.h and utility.c or similar to round up a
lot of these.
Regardless,
I am really Ok with Janne's patch and more then grateful for the asyncio
endeavor he is launching into.
Jerry
More information about the Fortran
mailing list