[Patch, libgfortran] PR 40330 Fix use of saved format strings
Jerry DeLisle
jvdelisle@verizon.net
Thu Jun 4 00:06:00 GMT 2009
Janne Blomqvist wrote:
> On Wed, Jun 3, 2009 at 22:00, Janne Blomqvist <blomqvist.janne@gmail.com> wrote:
>> Hi,
>>
>> the attached patch fixes PR 40330. The problem was that for the saved
>> format strings we were just keeping pointer to the strings that reside
>> in the st_parameter_dt structure. However, this lives on the stack so
>> once it goes out of scope the cached entries became invalid. Fixed by
>> using heap storage.
>>
>> Regtested on x86_64-unknown-linux-gnu, Ok for trunk and 4.4?
>
> Upon some further though, realloc() is not appropriate here.
> Simplified patch attached.
>
> Regtested on x86_64-unknown-linux-gnu, Ok for trunk and 4.4?
>
Yes and Yes,
Thanks to Joost for spotting this and reducing the test case.
Thanks Janne for quick response. (the realloc made me nervous :) )
Jerry
More information about the Fortran
mailing list