[patch, fortran] warnings on truncated lines with \r\n line-endings
Daniel Franke
franke.daniel@gmail.com
Wed Feb 18 19:42:00 GMT 2009
On Wednesday 18 February 2009 17:24:02 you wrote:
> > Attached mini-patch fixes this by skipping the '\r' character without
> > setting 'trunc_flag'.
> >
> > I'd claim it's obvious for 4.5, but would it be ok for 4.4 as well?
>
> This patch is OK since we don't support the old Mac format of having
> '\r' instead of '\n' or '\r\n'. I think it is trivial enough to be OK
> for 4.4, but I'm also open for other comments.
Thanks. I'll postpone the commit for a while for others to comment, though.
> Any idea what goes wrong with your PR 39229 (which definitely looks more
> like 4.5 item)?
Not yet, no. Haven't looked into it too deeply, just came across it this
morning while trying to get rid of loads of warnings in files I inherited.
Cheers
Daniel
More information about the Fortran
mailing list