[Patch, Fortran] PR42484: ICE with -fopenmp

[Jerry DeLisle]

On 12/28/2009 01:38 PM, Janus Weil wrote:
> 2009/12/28 Jakub Jelinek<jakub@redhat.com>:
>> On Mon, Dec 28, 2009 at 09:42:54PM +0100, Janus Weil wrote:
>>> here is my patch for this PR. It took me a while to find the root of
>>> the ICE (for history see the PR log).
>>
>> This is wrong
>
> What is wrong? Can you be a bit more specific?
>
>
Good question.  I have had this happen to me before where I spent a bit of time 
on a patch to find out someone else was working it as well.  In this case HJ's 
patch was from a different angle.

Your solution is only wrong in the sense that omp-low.c was completely not 
handling GIMPLE_COND which is the root problem.  I think your patch, most 
logically, avoided this condition.  Nothing wrong with that at all really, but 
would have allowed the gimplify problem to persist for the next guy down the 
rail road to not see the missing train tracks.

Cheers,

Jerry