[Patch, libfortran] PR 40812 Large file support on MinGW

[Janne Blomqvist]

On Wed, Dec 2, 2009 at 04:14, Jerry DeLisle <jvdelisle@verizon.net> wrote:
> On 12/01/2009 10:57 AM, Janne Blomqvist wrote:
>>
>> On Tue, Dec 1, 2009 at 20:18, Janne Blomqvist<blomqvist.janne@gmail.com>
>>  wrote:
>>>
>>> Hi,
>>>
>>> the attached patch should make gfortran support>  2 GB files on MinGW.
>>> I don't have a windows installation to test on, so I don't know if
>>> this works or not. Though I regtested on x86_64-unknown-linux-gnu to
>>> make sure that non-MinGW targets didn't change (it's all behind
>>> #ifdefs, but just to be sure).
>>>
>>> Another caveat is that it uses features from the Win32 API that
>>> according to MSDN are available only as of w2k and newer, so with this
>>> patch we effectively drop support for pre-w2k targets on MinGW. I
>>> don't know if anybody cares about such platforms any longer, if so
>>> maybe the interested party could step up to the plate and contribute
>>> some configure checks or somesuch so that we could fall back to the
>>> old ftruncate or chsize functions?
>>>
>>> Ok for trunk?
>>>
> --- snip ---
>
> I have not had a chance to review closely yet.  I would like to get some
> real test results from a MinGW maintainer to confirm before we proceed with
> this.

Hi,

on IRC Kai Tietz reported that the patch regtested on mingw with no
new regressions, and also the large file testcase in the PR went
successfully.

OTOH Danny Smith has offered to contribute an implementation that
doesn't break pre-w2k backwards compatibility, so I think it's best to
put this on hold for a short while until he resurfaces with a patch.


-- 
Janne Blomqvist