[patch, fortran] [4.4 Regression] Incorrect array value returned

Daniel Kraft d@domob.eu
Sun Sep 21 06:45:00 GMT 2008


Jerry DeLisle wrote:
> This PR should be called "4.3 ABI Broken"
> 
> The attached patch is experimental, proof of principle.  I am requesting 
> that everyone who can, please review and test this.  I am sure that the 
> ugliness in io.h can be cleaned up.  The purpose of it all was to align 
> the st_parameter_dt for 4.3 executables but still work for 4.4

Hi Jerry,

while I can't say anything about the details, your patch and way to 
seperate 4.3 and 4.4 looks indeed good to me.

-      char pad[16 * sizeof (char *) + 32 * sizeof (int)];
+      char pad[32 * sizeof (char *) + 32 * sizeof (int)];

Without knowing any details or having thought through it, I just wonder 
if this could be a problem with 4.3 compiled programs vs. 4.4 library? 
Not necessarily because the library tries to access the "extended" 
fields (which it should not do with your seperation of course) but maybe 
some issues with memory allocation or something like that?  But probably 
we're safe here, too.

Yours,
Daniel

-- 
Done:     Arc-Bar-Cav-Sam-Val-Wiz, Dwa-Elf-Gno-Hum-Orc, Law-Neu-Cha, Fem-Mal
To go:    Hea-Kni-Mon-Pri-Ran-Rog-Tou



More information about the Fortran mailing list